-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Ownership Library for better UX #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I review the changes themselves can you elaborate on the technical need for this change?
To me it seems like a subjective change in UX.
I think that having the ability to set data at compile time is important and useful. At the same time being able to delay that via a constructor may be useful as well.
Without deeper consideration at this stage I'll await your response and instead superficially propose the idea of having 2 ownership standards. One for configuration and one for construction. That has trade-offs as well but I don't think that's as much of an issue as providing one UX over the other.
This is something I considered, but there are a few caveats to this.
I believe the proposed changes make Sway code significantly more readable and less verbose. Having to call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan of the UX improvements here. Just a couple of comments for the README, but they're only suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
Type of change
Changes
The following changes have been made:
StorageKey
to store storage. This results in the following improvements in developer UX as the use of the library was previously very verbose.Before:
After:
The downside to this approach is the inability to set the owner during compile time and a constructor must be implemented.